Skip to content

Migrated plugins.jquery.com to the new-new-css #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 16, 2012
Merged

Migrated plugins.jquery.com to the new-new-css #99

merged 6 commits into from
Oct 16, 2012

Conversation

dnschnur
Copy link
Contributor

I've migrated the plugins site to the new-new CSS framework.

This resolves jquery-archive/plugins.jquery.com#53. I also reviewed the media queries and resolved various issues when viewing on smaller screen sizes.

Mostly straightforward migration to the new-new CSS framework,
cross-referencing the new foundation site with the old stage.jquery.com.

Major changes include:
- Split the sidebar from content-jquery_plugin.php off into its own
include, sidebar-jquery_plugin.php
- Removed several no-longer-necessary wrapper divs
- Cleaned-up style.css organization; it had gotten messy

Remaining issues:
- Single-plugin page project info is still broken
- Lots of pruning still required to remove styles that are now in base
- Media queries haven't yet been migrated
Mostly straightforward migration to the new-new CSS framework,
cross-referencing the new foundation site with the old stage.jquery.com.

Major changes include:
- Split the sidebar from content-jquery_plugin.php off into its own
include, sidebar-jquery_plugin.php
- Removed several no-longer-necessary wrapper divs
- Cleaned-up style.css organization; it had gotten messy

Remaining issues:
- Single-plugin page project info is still broken
- Lots of pruning still required to remove styles that are now in base
- Media queries haven't yet been migrated
Fixed plugin title and info styles, plus various minor fixes.
Updated media queries to work with the new markup, plus additional
tweaks to make scaling smoother between 480px and 900px.
Fixed various bugs (which existed prior to new-new-css) in the way the
single-plugin info page scaled to smaller screen sizes.
@dnschnur
Copy link
Contributor Author

Note the weird duplication of commits. I synced with my fork earlier this morning, giving it 348c33c. When I used the Github Windows client to sync my subsequent commits, it encountered an error. Checking from the command-line, git claimed that my tip was behind the remote. So I did a pull, which produced the duplicate commit 5a446b8. This produced some merge conflicts, which I resolved in 152da6b.

Aside from the superfluous commits everything appears to be fine now; I've never encountered this problem before.

rdworth added a commit that referenced this pull request Oct 16, 2012
Migrated plugins.jquery.com to the new-new-css
@rdworth rdworth merged commit ac51edc into jquery:new-css Oct 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants